test: demand control non-clobbery#8840
Closed
aaronArinder wants to merge 25 commits intocaroline/demand-control-by-subgraphfrom
Closed
test: demand control non-clobbery#8840aaronArinder wants to merge 25 commits intocaroline/demand-control-by-subgraphfrom
aaronArinder wants to merge 25 commits intocaroline/demand-control-by-subgraphfrom
Conversation
chore: refactor config name to match convention
When different list size parameters are set (especially for specific subgraphs), it will radically change the estimated cost
these don't add anything, and they just slow down the run
10 tasks
carodewig
force-pushed
the
caroline/demand-control-by-subgraph
branch
from
a2526bd to
aee2352
Compare
Contributor
|
Cherry-picked the commit because I made the mistake of rebasing 😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a test that should fail if we change out dashmap for something dangerous when doing demand control (we probably wouldn't, but for whatever reason this is a weird itch for me)
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩